Fix crash when adding BugsnagReactNativePlugin #1392
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fix crash when starting Bugsnag with
BugsnagReactNativePlugin
.BugsnagClient
expectsself.configuration.plugins
to be of typeNSMutableSet
as advertised.bugsnag-cocoa/Bugsnag/Client/BugsnagClient.m
Lines 253 to 256 in 96f738f
This bug has prevented updating bugsnag-cocoa in bugsnag-js
Changeset
Ensure
plugins
is a mutable set when copying aBugsnagConfiguration
.Testing
Amends unit test to replicate problem and verify fix.