Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add watchOS BugsnagNetworkRequestPlugin scheme #1373

Merged
merged 6 commits into from
May 19, 2022

Conversation

kstenerud
Copy link
Contributor

@kstenerud kstenerud commented May 18, 2022

Xcode sometimes lies about creating a public scheme for a target. You have to manually unselect "public" and then re-select it to generate the file :/

Also fixed up the watchOS versions for the network plugin targets. Minimum OS is 6.0 (where NSURLSessionTaskMetrics are introduced)

@kstenerud kstenerud requested a review from nickdowell May 18, 2022 09:17
@github-actions
Copy link

github-actions bot commented May 18, 2022

Bugsnag.framework binary size decreased by 3,816 bytes from 819,568 to 815,752 🎉

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +6.7% +1.00Ki  +6.6% +1.00Ki    [__TEXT]
   +12%    +916  +6.3%    +916    [__DATA]
  -2.1%      -8  -2.1%      -8    __DATA,__objc_classlist
  -0.1%      -8  -0.1%      -8    __DATA,__objc_selrefs
  -3.0%      -8  -3.0%      -8    __DATA,__objc_superrefs
  -1.0%     -12  -1.0%     -12    __TEXT,__objc_classname
  -0.8%     -16  -0.8%     -16    Function Start Addresses
  -2.0%     -20  -2.0%     -20    __DATA,__objc_ivar
  -1.2%     -24  -1.2%     -24    Rebase Info
  -0.8%     -28  -0.8%     -28    __TEXT,__unwind_info
  -1.2%     -36  -1.2%     -36    __TEXT,__objc_methtype
  -0.4%     -40  -0.4%     -40    Export Info
  -2.1%     -80  -2.1%     -80    __DATA,__objc_data
  -1.2%    -339  -1.2%    -339    __TEXT,__objc_methname
  -0.2%    -612  -0.2%    -612    __TEXT,__text
  -1.5%    -792  -1.5%    -792    __DATA,__objc_const
  -1.2% -1.69Ki  -1.2% -1.69Ki    Symbol Table
  -1.1% -1.96Ki  -1.1% -1.96Ki    String Table
  [ = ]       0 -78.5% -12.3Ki    [__LINKEDIT]
  -0.5% -3.73Ki  -1.9% -16.0Ki    TOTAL

Generated by 🚫 Danger

@kstenerud kstenerud force-pushed the watchos-network-plugin-scheme branch from 9720238 to 1ecaed8 Compare May 18, 2022 09:43
@kstenerud kstenerud force-pushed the watchos-network-plugin-scheme branch 2 times, most recently from 19a8cea to 1142a92 Compare May 18, 2022 12:29
@kstenerud kstenerud force-pushed the watchos-network-plugin-scheme branch from 1142a92 to 158ce54 Compare May 18, 2022 14:15
@nickdowell nickdowell force-pushed the watchos-network-plugin-scheme branch from 1ec17a8 to 7a41253 Compare May 19, 2022 08:11
@kstenerud kstenerud merged commit 0b52188 into integration/watchos May 19, 2022
@kstenerud kstenerud deleted the watchos-network-plugin-scheme branch May 19, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants