Skip unnecessary file reading at startup #1334
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Improve notifier start time by doing less work.
Changeset
Defers reading
config.json
,metadata.json
andstate.json
until building an OOM or Thermal Kill event (if detected) rather than reading them in-[BugsnagClient initWithConfiguration:]
.Testing
Verified by running E2E tests locally - in particular
features/barebone_tests.feature:190
andfeatures/out_of_memory.feature:11
that ensure various items are correctly set in the payload, and running a full E2E on iOS 10 on CI.