Don't check session data contents if they are nil #1301
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
When a session is resumed, we send an update notification with a nil object to indicate that there's no new session info to update:
In our update handler, it fails the JSON check so the data doesn't get updated (as we want), but it also prints out an ominous error message:
This PR does an explicit nil check so that it doesn't print an error message on session resume.
Testing
Reran e2e tests