[PLAT-6629] Fix crash if app dSYM UUID could not be found #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
See #1097
Changeset
The
dsymUUIDsarray is now accessed using the saferfirstObjectmethod rather than subscripting.The app's main binary image is now identified by having a
LC_MAIN(orLC_UNIXTHREAD) load command, rather than through potentially unreliable string matching.The mach headers list is now initialized on demand, since it was found that the app UUID is requested before
bsg_mach_headers_register_for_changes()was being called.Testing
The new method has been tested manually using a sample app. E2E tests verify that
dsymUUIDsis present and not empty.