[PLAT-6346] Fix deadlock in bsg_recordException() #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstenerud
approved these changes
Apr 26, 2021
kattrali
approved these changes
Apr 26, 2021
Merged
This was referenced May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Some flakiness in E2E tests was being caused by a deadlock in the NSException crash handler.
When the test(s) failed,
Filling out context.was the last log output from the test fixture.Design
The deadlock occurred because
mallocand the objc runtime were being called while other threads were suspended and may be holding a lock.Changeset
bsg_kscrashsentry_suspendThreads()is now called immediately before calling the main crash handler.Testing
Was not able to reproduce the deadlock manually, however the E2E tests pass with this fix.