[PLAT-6261] Detect uncaught objc exceptions on Mac Catalyst and iOSAppOnMac #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickdowell
force-pushed
the
nickdowell/ios-app-on-mac-uncaught-exception-handling
branch
from
5620944
to
2613411
Compare
kattrali
approved these changes
Mar 29, 2021
| // iOS apps behave a little differently when running on macOS via Catalyst or | ||
| // on Apple Silicon. Uncaught NSExceptions raised while handling UI events get | ||
| // caught by AppKit and are not propagated to NSUncaughtExceptionHandler or | ||
| // std::terminate_handler, therefore we need another way to detect them... |
There was a problem hiding this comment.
I'd add the feedback number here as a reference for future travelers, both to note that its related to an ongoing issue and to make it easier to know when to remove this code if the issue is ever addressed. (maybe also in the changelog?)
nickdowell
deleted the
nickdowell/ios-app-on-mac-uncaught-exception-handling
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
iOS apps running on Mac Catalyst or on Macs with Apple Silicon were not having uncaught exceptions reported when thrown from a UI event handler.
The normal mechanisms we use to detect exceptions (
NSUncaughtExceptionHandlerorstd::terminate_handler) are not triggered due to the way AppKit has historically dealt with exceptions.Changeset
Bugsnag now hooks into
-[NSApplication reportException:]to detect uncaught exceptions.Testing
Tested using a sample project targeting Mac Catalyst and on a Mac mini with Apple silicon.