Prevent ConcurrentModificationException thrown from Metadata class #935
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Prevents a
ConcurrentModificationException
from being thrown in the internally usedMetaData
class.MetaData
does correctly use aConcurrentHashMap
as the default value for thestore
property, but within thecopy()
method supplies a regularHashMap
. Wheneverclient.notify()
is invoked the global metadata state is copied, which can result in aConcurrentModificationException
being thrown in subsequent edits.This changeset resolves the problem by enforcing that
store
must be aConcurrentHashMap
.Testing
Added a unit test which throws an exception without the changes, and confirmed that it no longer throws an exception.