Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear the stack-trace memory to avoid UTF-8 encoding problems #1543

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

lemnik
Copy link
Contributor

@lemnik lemnik commented Dec 3, 2021

Goal

Ensure that bugsnag_notify_env does not fail due to uninitialised memory in the captured stack trace.

Testing

Added a new function to the native mazerunner scenarios which will "dirty" the stack to emulate the behaviour of a longer running application. The function simply populates a 1Mb temporary array with data and returns.

@lemnik lemnik force-pushed the PLAT-7701/clear-notify-stacktrace branch from 5600cfe to 2dd97f3 Compare December 3, 2021 14:21
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Dec 3, 2021

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1353.36 1168.19
arm64_v8a 483.72 299.4
armeabi -492.59 -21.55
armeabi_v7a 455.06 270.74
x86 520.57 340.35
x86_64 508.29 323.97

Generated by 🚫 Danger

Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lemnik lemnik force-pushed the PLAT-7701/clear-notify-stacktrace branch from 2dd97f3 to 470677f Compare December 8, 2021 08:15
@lemnik lemnik force-pushed the PLAT-7701/clear-notify-stacktrace branch from 470677f to 11c4bd9 Compare December 8, 2021 10:44
@lemnik lemnik merged commit 900f3b1 into next Dec 8, 2021
@lemnik lemnik deleted the PLAT-7701/clear-notify-stacktrace branch December 8, 2021 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants