Hook service #2
Hook service #2
Conversation
| uint32 port = 2; | ||
| } | ||
|
|
||
| message EnableTpuRequest { |
There was a problem hiding this comment.
is this referring to validator's local tpu?
| bool enable_tpu_fwd = 2; | ||
| } | ||
|
|
||
| message EnableTpuResponse {} |
| } | ||
|
|
||
| message SendPacketsRequest { | ||
| bool admin = 1; |
There was a problem hiding this comment.
can you leave a comment on what this is?
| @@ -0,0 +1,93 @@ | |||
| syntax = "proto3"; | |||
There was a problem hiding this comment.
is this generally an admin hook service? if so can you leave a comment on that
|
|
||
| message SetShredForwarderAddressResponse {} | ||
|
|
||
| message SetMaxComputeRequest { |
There was a problem hiding this comment.
can you rename to something that's obvious this is related to bundle CU reserve
| message SetMaxComputeResponse {} | ||
|
|
||
| message Bundle { | ||
| bool admin = 1; |
| message Bundle { | ||
| bool admin = 1; | ||
| repeated Packet packets = 2; | ||
| string uuid = 3; |
There was a problem hiding this comment.
bundle ids are not UUIDs anymore, rename to id
| // Sends packets into the BankingStage of the validator | ||
| rpc SendPackets(stream SendPacketsRequest) returns (SendPacketsResponse); | ||
|
|
||
| // Marks accounts for discard |
| rpc MarkAccountsForDiscard(MarkAccountsForDiscardRequest) returns (MarkAccountsForDiscardResponse); | ||
|
|
||
| // Sets the shred forwarder addresses | ||
| rpc SetShredForwarderAddress(SetShredForwarderAddressRequest) returns (SetShredForwarderAddressResponse); |
There was a problem hiding this comment.
could also consider having broadcast stream packets back to sidecar and have that manage shred forwards. down side is if side car crashes so does shred forward
| bool enable_tpu_fwd = 2; | ||
| } | ||
|
|
||
| message EnableTpuResponse {} |
There was a problem hiding this comment.
ditto on most of the other SetXXX methods
| } | ||
|
|
||
| message SendPacketsRequest { | ||
| bool admin = 1; |
| message SetMaxComputeResponse {} | ||
|
|
||
| message Bundle { | ||
| bool admin = 1; |
|
|
||
| message SendBundleRequest { | ||
| repeated Bundle bundles = 1; | ||
| uint64 slot_expiration = 2; |
There was a problem hiding this comment.
is this inclusive or exclusive? eg if slot = 5, do we still consider the bundle on slot 5?
Problem
Summary of Changes
Fixes #