add upgrade_core_bpf_program module
#2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalojoec
force-pushed
the
migrate-native-program
branch
from
e7156cb to
fe3398e
Compare
buffalojoec
changed the title
migrate_native_program moduleupgrade_core_bpf_program module
buffalojoec
commented
Nov 21, 2023
| #[allow(dead_code)] | ||
| pub fn upgrade_core_bpf_program( | ||
| bank: &Bank, | ||
| target: NativeProgram, |
There was a problem hiding this comment.
Because of this parameter, it might make sense to rename the enum from NativeProgram to something like CoreProgram. Or we can use a type alias, ie: type NativeProgram = CoreProgram;.
buffalojoec
force-pushed
the
migrate-native-program
branch
from
fe3398e to
a7c1f7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a draft for now! As talks on SIMD XXXX continue, I'll jot notes here.
One major note: We'll need to roll a CLI change in order to deploy a program in its finalized version using the non-upgradeable loader. This is necessary since Core BPF programs must be owned by the non-upgradeable loader and must not have a program data account.