Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buf-breaking-action #4

Merged
merged 6 commits into from
Nov 9, 2023
Merged

Conversation

smallsamantha
Copy link
Member

No description provided.

@nicksnyder
Copy link
Member

I think we should allow breaking changes for a bit.

.github/workflows/buf.yaml Outdated Show resolved Hide resolved
.github/workflows/buf.yaml Outdated Show resolved Hide resolved
@pkwarren
Copy link
Member

I think we should allow breaking changes for a bit.

We could technically enable this now because ignore_unstable_packages set:

ignore_unstable_packages: true

bufdev and others added 3 commits November 5, 2023 15:26
Co-authored-by: Philip K. Warren <[email protected]>
Co-authored-by: Philip K. Warren <[email protected]>
Co-authored-by: Philip K. Warren <[email protected]>
@bufdev
Copy link
Member

bufdev commented Nov 5, 2023

Conflicts need to be resolved, and we should take @pkwarren's suggestion and use major versions for GitHub Actions... @smallsamantha can you update this and then we can merge? As @pkwarren said, we can enable this since we have ignore_unstable_packages set to true.

@smallsamantha smallsamantha marked this pull request as ready for review November 9, 2023 17:50
@smallsamantha smallsamantha merged commit aaf0d58 into main Nov 9, 2023
7 checks passed
@smallsamantha smallsamantha deleted the smallsamantha/buf-breaking branch November 9, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants