Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust validation for VCS Commit Hash #29

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

jchadwick-buf
Copy link
Member

We currently only support Git SHA1 hashes and nothing else. In the future, adding a union to this regex could allow more hash shapes for different VCSes or different Git repository digests.

@jchadwick-buf jchadwick-buf requested a review from bufdev as a code owner November 8, 2023 18:32
@bufdev bufdev merged commit 7bc904b into main Nov 9, 2023
4 checks passed
@bufdev bufdev deleted the jchadwick/vcs-commit-hash-validation branch November 9, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants