Skip to content

Commit

Permalink
move atomicity comment to RPC
Browse files Browse the repository at this point in the history
  • Loading branch information
nicksnyder committed Nov 7, 2023
1 parent d9e2a42 commit d1fd51e
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions buf/registry/module/v1beta1/commit_service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,13 @@ service CommitService {
rpc ListCommitHistory(ListCommitHistoryRequest) returns (ListCommitHistoryResponse) {
option idempotency_level = NO_SIDE_EFFECTS;
}
// Create commits on a Module with associated Content.
// Create commits on a Module with associated content (e.g. blobs, branches, tags).
//
// This is used by push and sync.
//
// This operation is atomic. Either all Commits and associated content are created, or an error happens and none of
// them are created.
//
// TODO: PushCommits? Something else? This is creating potentially a bunch of resources.
rpc CreateCommits(CreateCommitsRequest) returns (CreateCommitsResponse) {
option idempotency_level = IDEMPOTENT;
Expand Down Expand Up @@ -222,8 +225,6 @@ message CreateCommitsRequest {
//
// If there are already VCSCommits on the associated Module with a given hash, this
// will result in an error. Otherwise, a new VCSCommit is created.
//
// This operation is atomic. Either all Commits are created, or an error happens and none of them are created.
repeated AssociatedVCSCommit associated_vcs_commits = 6;
}

Expand Down

0 comments on commit d1fd51e

Please sign in to comment.