Respect !!str tag for structpb unmarshal #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I observed that structpb string values that can be parsed as an int do not roundtrip through protoyaml. This commit adds some failing test cases to TestValue_Dynamic and updates unmarshalScalarString to return a StringValue if the !!str tag is present.
|
|
|
Let me know if this change seems reasonable, if so I can look into sorting out the CLA situation |
|
This looks good to me. |
Alfus
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I observed that when a
structpb.Value_StringValuecan be parsed as a number it does not roundtrip through protoyaml.This commit adds some failing test cases to
TestValue_Dynamicand updatesunmarshalScalarStringto return aValue_StringValueif the!!strtag is present.Let me know if I'm missing something, I'm new to working with YAML!