-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add isIpPrefix #45
Add isIpPrefix #45
Conversation
- [x] protovalidate-go: bufbuild/protovalidate-go#53 - [x] protovalidate-cc: bufbuild/protovalidate-cc#45 (via @paina) - [x] protovalidate-java: bufbuild/protovalidate-java#39 - [x] protovalidate-python: bufbuild/protovalidate-python#78 --------- Co-authored-by: Chris Roche <[email protected]>
@paina looks like there's still some wiring missing to define the CEL functions. Want to take a stab it? |
Getting an error running the conformance tests locally on MacOS Sonoma:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. I left a couple of comments mostly regarding portability. I also think if possible it would be better to avoid std::pow
, which will use floating point math, if using simple bit-twiddling would suffice instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related to: bufbuild/protovalidate#99
Based on @higebu's idea on the PR, I've implemented
isIpPrefix()
for C++.