Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppose we have
m map[intern.ID]T
ands string
. We want to query if this string is in the map. We could writem[table.Intern(s)]
, but ifs
is not already interned, this is quite wasteful! Interning a never-before-seen string costs three map hits, plus the hit tom
. However, ifs
is not interned, it cannot possibly be inm
, so we can cut the cost of every lookup to one hit inQuery
and one inm[id]
.In other words, this lets us write this function:
char6-inlined IDs are treated as always being interned, which means that for very small IDs, we only have to hit one map: the lookup in
m[id]
.