Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrections to the spec #3

Merged
merged 2 commits into from
Sep 16, 2022
Merged

corrections to the spec #3

merged 2 commits into from
Sep 16, 2022

Conversation

jhump
Copy link
Member

@jhump jhump commented Sep 16, 2022

Recently identified bugs in the spec:

  1. Fixing some minor omissions about constraints on package name length and depth of nested messages.
  2. Fixing an omission about the constraints of octal and hexadecimal integer literals. Until recently, decimal literals had the same constraint, but were then treated inconsistently when a negative sign was applied (based on whether the context was a normal or custom option value or a field default value). Instead of describing that behavior, the spec now describes the behavior of the next release of protoc (which will include this fix).
  3. The final change is a straight up error in the spec. I think I wrote the paragraph on extensions in message literals from memory instead of looking at actual code. I even fixed this recently in protoparse, but failed to recall when I wrote this. This fixes that mistake.

@vercel
Copy link

vercel bot commented Sep 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
protobuf-com ✅ Ready (Inspect) Visit Preview Sep 16, 2022 at 3:22PM (UTC)

@jhump jhump requested a review from pkwarren September 16, 2022 15:01
@jhump
Copy link
Member Author

jhump commented Sep 16, 2022

@pkwarren, you'll notice that these are all related to recent changes in protocompile (yours and mine). So hopefully you don't mind me tagging you as the reviewer for this repo, too :)

docs/language-spec.md Outdated Show resolved Hide resolved
docs/language-spec.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants