Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copyedit docs and migrate content from v1 #930

Merged
merged 24 commits into from
Jul 17, 2024
Merged

Copyedit docs and migrate content from v1 #930

merged 24 commits into from
Jul 17, 2024

Conversation

rakuista
Copy link
Member

No description provided.

timostamm
timostamm reviewed Jul 11, 2024
View reviewed changes
MANUAL.md Outdated Show resolved Hide resolved
MANUAL.md Outdated Show resolved Hide resolved
timostamm
timostamm reviewed Jul 12, 2024
View reviewed changes
MANUAL.md Outdated Show resolved Hide resolved
MANUAL.md Outdated Show resolved Hide resolved
MANUAL.md Outdated Show resolved Hide resolved
MANUAL.md Outdated Show resolved Hide resolved
MANUAL.md Outdated Show resolved Hide resolved
timostamm
timostamm reviewed Jul 16, 2024
View reviewed changes
Copy link
Member

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments and fixed links in 48c95c1 and 6fd7e22.

I'd like to condense "Writing plugins" a bit. But I think we should merge this and it's parent #926 first.

packages/protoc-gen-es/README.md Outdated Show resolved Hide resolved
packages/protoc-gen-es/README.md Outdated Show resolved Hide resolved
packages/protoc-gen-es/README.md Outdated Show resolved Hide resolved
packages/bundle-size/README.md Show resolved Hide resolved
MANUAL.md Outdated Show resolved Hide resolved
MANUAL.md Outdated Show resolved Hide resolved
MANUAL.md Outdated Show resolved Hide resolved
MANUAL.md Outdated Show resolved Hide resolved
MANUAL.md Outdated Show resolved Hide resolved
@rakuista rakuista marked this pull request as ready for review July 16, 2024 20:32
@rakuista rakuista changed the title WIP: Copyedits and content migration from v1 Copyedits and content migration from v1 Jul 16, 2024
@rakuista rakuista requested a review from timostamm July 16, 2024 20:32
@rakuista rakuista changed the title Copyedits and content migration from v1 Copyedit docs and migrate content from v1 Jul 16, 2024
timostamm
timostamm approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rakuista!

@timostamm timostamm merged commit 2363047 into tstamm/manual Jul 17, 2024
3 of 4 checks passed
@timostamm timostamm deleted the v2-docs-edits branch July 17, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timostamm timostamm timostamm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rakuista @timostamm