Partially improve TypeScript compatibility tests #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This partially gets us to the goals defined in #581. We do not remove the dependency on `@types/node` yet, but we make sure to use the corresponding version for every version of TypeScript we test with. To speed up GitHub actions, the compatibility tests are moved to a separate job that runs in parallel.
timostamm
commented
Oct 25, 2023
Comment on lines
+6
to
+8
| "build": "../../node_modules/typescript/bin/tsc --noEmit", | ||
| "add-person": "tsx src/add-person.ts addressbook.bin", | ||
| "list-people": "tsx src/list-people.ts addressbook.bin", |
There was a problem hiding this comment.
A drive-by change. We have been using tsx in our examples everywhere but here.
smaye81
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially gets us to the goals defined in #581. We do not remove the dependency on
@types/nodeyet, but we make sure to use the corresponding version for every version of TypeScript we test with.To speed up GitHub actions, the compatibility tests are moved to a separate job that runs in parallel.