Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type exports and integrate arethetypeswrong #565

Merged
merged 8 commits into from
Sep 28, 2023
Merged

Fix type exports and integrate arethetypeswrong #565

merged 8 commits into from
Sep 28, 2023

Conversation

smaye81
Copy link
Member

@smaye81 smaye81 commented Sep 27, 2023

Our type exports are incorrect for the Node16 module resolution algorithm: When @bufbuild/protobuf is used with lib checks enabled, TypeScript raises the error TS1479. For a more detailed description, see connectrpc/connect-es#679.

This integrates the arethetypeswrong CLI tool for checking types in published packages. It also adds the call to lint the types in CI that it is easy to spot regressions.

Copy link
Member

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Please make sure to close #456 🙂

@smaye81 smaye81 merged commit 1ad9d3d into main Sep 28, 2023
3 checks passed
@smaye81 smaye81 deleted the sayers/attw branch September 28, 2023 14:12
@timostamm timostamm changed the title Integrate arethetypeswrong Fix type exports and integrate arethetypeswrong Oct 5, 2023
@timostamm timostamm mentioned this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants