Differentiate producer/consumer configuration #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshayjshah
approved these changes
Oct 7, 2024
bufdev
approved these changes
Oct 7, 2024
| @@ -28,14 +28,21 @@ type Config struct { | |||
| } | |||
|
|
|||
| // NewKafkaClient returns a new franz-go Kafka Client for the given Config. | |||
| func NewKafkaClient(config Config) (*kgo.Client, error) { | |||
| func NewKafkaClient(config Config, consumer bool) (*kgo.Client, error) { | |||
There was a problem hiding this comment.
To unblock, approving PR, but would prefer we split this out into NewKafkaConsumerClient and NewKafkaProducerClient for demo clarity - I can do this in a follow-up though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The producer/consumer code was sharing the same configuration, which means the producer was being initialized as a consumer as well. If the producer starts first, it joins the same group and is assigned the only partition for the topic. When the consumer eventually comes online, it joins the group but is not assigned the partition, appearing to be stuck. This patch bifurcates the configuration on whether or not the Kafka client being stood up should be a consumer. Also, the PR adds a few hygienic options that should always be set for consumers (read committed, require stable offsets).