pkg/thread: add a simple test #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's difficult to test all the timing conditions in Parallelize, but we can easily test the most basic use cases.
akshayjshah
force-pushed
the
ajs/select
branch
from
cac9905 to
dd18913
Compare
amckinney
approved these changes
Feb 3, 2022
johanbrandhorst
approved these changes
Feb 3, 2022
bufdev
reviewed
Feb 3, 2022
| ) | ||
|
|
||
| func TestParallelizeWithImmediateCancellation(t *testing.T) { | ||
| // The bulk of the code relies on subtle timing that's difficult to |
There was a problem hiding this comment.
Needs a t.Parallel(), im surprised lint didnt catch this
There was a problem hiding this comment.
I'm tempted to make one of those Xzibit memes about parallel testing for parallelize, but even reading the template confuses me.
Monirul1
pushed a commit
to Monirul1/buf
that referenced
this pull request
Apr 30, 2023
It's difficult to test all the timing conditions in Parallelize, but we can easily test the most basic use cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's difficult to test all the timing conditions in Parallelize, but we
can easily test the most basic use cases.