Add proto definition of plugin display RPC #3538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
mfridman
reviewed
Dec 12, 2024
| @@ -29,6 +29,10 @@ service DisplayService { | |||
| rpc DisplayRepositoryElements(DisplayRepositoryElementsRequest) returns (DisplayRepositoryElementsResponse) { | |||
| option idempotency_level = NO_SIDE_EFFECTS; | |||
| } | |||
| // DisplayCheckPluginElements returns which check plugin elements should be displayed to the user. | |||
| rpc DisplayCheckPluginElements(DisplayCheckPluginElementsRequest) returns (DisplayCheckPluginElementsResponse) { | |||
There was a problem hiding this comment.
I think this should be DisplayPluginElements and the terminology should be "plugin" because even though there might be additional types of plugins, the plugin pages (like settings, etc.) should be the same?
cyinma
changed the title
mfridman
approved these changes
Dec 12, 2024
|
I hope one day we can find a better pattern to avoid the proliferation of RPCs for individual UI elements and also move this internally because it's very specific to our UI implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.