Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buf beta registry repository commands to use v1 API #3030

Merged
merged 47 commits into from
Jun 10, 2024

Conversation

oliversun9
Copy link
Contributor

@oliversun9 oliversun9 commented May 28, 2024

Update buf beta registry repository [create, delete, deprecate, get, list, undeprecate, update] to use v1 APIs (ModuleService).

The only behavioral change is updating the RepositoryPrinter's headers from Full name and Created to Full Name and Create Time.

Keep most of the variable names consistent with the existing code, when it comes to module vs repository. However, the oddity comes from the fact that most of these variables have type modulev1.Module. I'm happy to do a follow-up if that's desired.

@oliversun9 oliversun9 changed the base branch from main to osun/migrate-beta-registry-organization-to-use-v1-api June 5, 2024 20:36
@oliversun9 oliversun9 changed the title [Do not merge] Update buf beta registry repository commands to use v1 API Update buf beta registry repository commands to use v1 API Jun 7, 2024
@oliversun9 oliversun9 marked this pull request as ready for review June 7, 2024 21:18
@oliversun9 oliversun9 requested review from bufdev and doriable June 7, 2024 21:18
Base automatically changed from osun/migrate-beta-registry-organization-to-use-v1-api to main June 10, 2024 18:02
@oliversun9 oliversun9 merged commit 35a9087 into main Jun 10, 2024
9 checks passed
@oliversun9 oliversun9 deleted the osun/migrate-beta-repository-command-apis branch June 10, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants