Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and simplify buf.plugin.yaml configuration #1226

Merged
merged 2 commits into from
Jun 23, 2022

Conversation

amckinney
Copy link
Contributor

This revises the buf.plugin.yaml according to the feedback in #1210. Specifically, this covers the following:

  • Remove archive runtime config
  • Simplify runtime configuration handling
  • Use modfile.GoVersionRE.MatchString
  • Cleanup bufpluginconfig.Config comment
  • Use separate runtime configuration shapes (e.g. separate go and npm runtime keys).

Note that there's one TODO left in the implementation surrounding npm runtime dependency validation. For now, we permit any non-empty string for the version. There might be some good solutions for this to capture exactly what npm does [not] support, but that isn't handled for now - we'll need to follow-up here.

@amckinney amckinney merged commit eb4c0c9 into main Jun 23, 2022
@amckinney amckinney deleted the amckinney/tcn-168-refactor-plugin-config branch June 23, 2022 18:08
Monirul1 pushed a commit to Monirul1/buf that referenced this pull request Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants