Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel linting support #664

Closed
tandel-pratik opened this issue Oct 15, 2021 · 4 comments
Closed

bazel linting support #664

tandel-pratik opened this issue Oct 15, 2021 · 4 comments
Labels
Feature New feature or request

Comments

@tandel-pratik
Copy link

It'd be great if we had linting support via bazel. We have a large monorepo and using bazel to lint would save a lot of time since it'd prevent recompiles.

@amckinney amckinney added Feature New feature or request P2 labels Oct 15, 2021
@amckinney
Copy link
Contributor

This is on the roadmap! It isn't our biggest priority right now, but expect to see this in the future. You can also follow along at #496 for some related tasks (i.e. we plan to accomplish this by reaching parity between buf protoc and protoc).

@amckinney
Copy link
Contributor

Also note that in the interim (before we have dedicated Bazel rules), you can actually use protoc-gen-buf-lint for this. It's actually built specifically for the bazel use case. Let us know if this helps you!

@tandel-pratik
Copy link
Author

Thanks @amckinney i also found that there's already support for this https://rules-proto-grpc.com/en/latest/lang/buf.html

and it might be worth you pointing folks there in the future.

@amckinney
Copy link
Contributor

Thanks @tandel-pratik! This issue has been superseded by a more general discussion on Bazel rules (#681).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants