-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to type trailing zeroes after the decimal separator #4
Conversation
Awesome! Thank you so much for this fix! But I think there is one small issue here that I we had |
@budiadiono of course I can, but for curiosity, how exactly did you reproduce the issue? I'm having a hard time with it. Can you give a more detailed explanation please? |
@bellini666 sure, you just need to run |
@budiadiono I was already running the example fine. I actually made this contribution testing the example. The screenshot I sent is also from it (notice the footer buttons) :) I asked how to reproduce the small issue you commented here. It seems that you are saying that when pressing |
Ohhh ok, I see the issue now hahaha. I think I didn't try to press the I'll take a look at that today or tomorrow and will update the PR :) |
@budiadiono it is done! If there're no more issues, it is ready to be merged! Oh, when you merge it and release a new version, can you ping me? I want to go back to your dep instead of using my fork in my |
OK Cool! Thank you so much @bellini666. I'll let you know soon when it get released. |
Hi @bellini666 it's released now! https://github.com/budiadiono/react-native-calculator/releases/tag/v0.5.0. |
@budiadiono awesome, thanks for the heads up :) |
This is to solve an issue where you could not type a
0
after the decimal separator. For example:If I had
1,
in the text, after typing0
it would become1
If I had
1.1
in the text, typing0
would do nothingThat means that I was not able to enter numbers like
1.01
or1.0101
for example.This PR should solve all those issues