Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Github Actions #383

Merged
merged 52 commits into from
Mar 23, 2021
Merged

Support for Github Actions #383

merged 52 commits into from
Mar 23, 2021

Conversation

renatonascalves
Copy link
Member

@renatonascalves renatonascalves commented Mar 13, 2021

fixes #377
fixes #384

@renatonascalves renatonascalves self-assigned this Mar 13, 2021
@renatonascalves
Copy link
Member Author

renatonascalves commented Mar 16, 2021

mysqlcheck: Got error: 1045: Access denied for user 'username_here'@'172.18.0.5' (using password: YES) when trying to connect
2

The error that's failing the CI was fixed at WordPress/gutenberg#29800 but was not sent to NPM yet. So this pull request will be blocked until that happens.

I'm also under the impression that the BuddyPress phpunit-wp-config.php file will have to be updated.

cc: @imath

@renatonascalves renatonascalves requested a review from imath March 19, 2021 23:31
Copy link
Contributor

@imath imath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your amazing job! Let's have this in 👍

@renatonascalves renatonascalves merged commit 5b7abde into master Mar 23, 2021
@renatonascalves renatonascalves deleted the github-actions branch March 23, 2021 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI Test against PHP 8.0 Move CI from Travis to Github Actions
2 participants