Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add the empty blob optimization to HTTP also #233

Closed
mostynb opened this issue Mar 23, 2020 · 0 comments
Closed

add the empty blob optimization to HTTP also #233

mostynb opened this issue Mar 23, 2020 · 0 comments
Assignees
@mostynb

Comments

@mostynb
Copy link
Collaborator

mostynb commented Mar 23, 2020

The gRPC API implementation has some special handling for empty blobs. IIRC bazel was uploading ActionResults which reference the empty blob without ever actually uploading the empty blob itself. Which is kind of OK, because the empty blob can be "regenerated" trivially.

Let's add the same feature for the HTTP API.
@mostynb mostynb self-assigned this Mar 23, 2020
mostynb added a commit to mostynb/bazel-remote that referenced this issue Mar 23, 2020
@mostynb
don't require explicit empty blob uploads for HTTP either
cbdf639 
The gRPC API implementation has a hack to handle clients (like bazel?)
which in some cases don't upload the empty blob, but do reference it.
It is kind of OK not to upload the empty blob, since it can be recognised
by hash and trivially regenerated.

Let's imlpement the hack for the HTTP API also.

Implements buchgr#233.
@mostynb mostynb mentioned this issue Mar 23, 2020
Merged
mostynb added a commit to mostynb/bazel-remote that referenced this issue Mar 24, 2020
@mostynb
don't require explicit empty blob uploads for HTTP either
e3c4c8a 
The gRPC API implementation has a hack to handle clients (like bazel?)
which in some cases don't upload the empty blob, but do reference it.
It is kind of OK not to upload the empty blob, since it can be recognised
by hash and trivially regenerated.

Let's imlpement the hack for the HTTP API also.

Implements buchgr#233.
mostynb added a commit that referenced this issue Mar 24, 2020
@mostynb
don't require explicit empty blob uploads for HTTP either
86ef1fd 
The gRPC API implementation has a hack to handle clients (like bazel?)
which in some cases don't upload the empty blob, but do reference it.
It is kind of OK not to upload the empty blob, since it can be recognised
by hash and trivially regenerated.

Let's imlpement the hack for the HTTP API also.

Implements #233.
@mostynb mostynb closed this as completed Mar 24, 2020
@scele scele mentioned this issue Apr 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mostynb mostynb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mostynb