-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support Angular 13 #208
Conversation
I need help with checks. I don't know how to fix the error received with |
It looks like Jasmine is using CommonJS module resolution, but ngrx/store not - it is using ES2020 module resolution. Can anyone help with handle this? |
Perhaps this thread on Jasmine supporting ESM can help? Or the setup instructions for using ESM with Jasmine? |
@piotter121 Thanks for your work. You seemed to be having trouble, so created pull request to your branch for fix test. I can't resolve mjs issue, so I removed outside package. These may be only constant, so I replaced. This can pass test. Please checked. Thanks. |
@piotter121 thanks for the PR and for taking time to try and sort out the module resolution problem. I had a go at fixing it as well but couldn't find a solution. Just had the one comment above. If you can take @rdlabo's changes into your PR I'm happy to merge this in. I'll probably just clean up the commits before I merge it to make the changelog a bit nicer and make sure the version is properly bumped. |
I have no access to a computer for the next few days. When I will be able to do so I check and merge PR. EDIT: |
BREAKING CHANGE: Bump min versions of Angular and NgRx packages to v13 Closes #206
Replace @ngrx/store INIT and UPDATE imports with hardcoded strings. This was done to fix a module resolution issue where the tests couldn't run
🎉 This PR is included in version 13.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
If anyone else wants to have a go at fixing the module resolution issue I raised a new issue for it here #212. |
Bump min versions of Angular and NgRx packages to v13
Summary
Support Angular and NgRx 13
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Current Behavior
Issue Number: #206
New Behavior
Breaking Change?
Other information