Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Angular 13 #208

Merged
merged 2 commits into from
Jan 21, 2022
Merged

feat: support Angular 13 #208

merged 2 commits into from
Jan 21, 2022

Conversation

piotter121
Copy link
Contributor

Bump min versions of Angular and NgRx packages to v13

Summary

Support Angular and NgRx 13

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines:
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Current Behavior

Issue Number: #206

New Behavior

Breaking Change?

  • Yes
  • No

Other information

@piotter121
Copy link
Contributor Author

I need help with checks. I don't know how to fix the error received with npm test.

@BBlackwo BBlackwo linked an issue Nov 28, 2021 that may be closed by this pull request
@BBlackwo BBlackwo added the dependencies Pull requests that update a dependency file label Nov 28, 2021
@piotter121
Copy link
Contributor Author

It looks like Jasmine is using CommonJS module resolution, but ngrx/store not - it is using ES2020 module resolution. Can anyone help with handle this?

@db6edr
Copy link

db6edr commented Dec 21, 2021

Perhaps this thread on Jasmine supporting ESM can help? Or the setup instructions for using ESM with Jasmine?

@rdlabo rdlabo mentioned this pull request Jan 10, 2022
@piotter121 piotter121 marked this pull request as draft January 17, 2022 06:18
@rdlabo
Copy link
Contributor

rdlabo commented Jan 17, 2022

@piotter121 Thanks for your work.

You seemed to be having trouble, so created pull request to your branch for fix test.
https://github.com/piotter121/ngrx-store-localstorage/pull/1

I can't resolve mjs issue, so I removed outside package. These may be only constant, so I replaced. This can pass test.

Please checked. Thanks.

@BBlackwo
Copy link
Collaborator

BBlackwo commented Jan 18, 2022

@piotter121 thanks for the PR and for taking time to try and sort out the module resolution problem. I had a go at fixing it as well but couldn't find a solution.

Just had the one comment above.

If you can take @rdlabo's changes into your PR I'm happy to merge this in. I'll probably just clean up the commits before I merge it to make the changelog a bit nicer and make sure the version is properly bumped.

@piotter121
Copy link
Contributor Author

piotter121 commented Jan 19, 2022

I have no access to a computer for the next few days. When I will be able to do so I check and merge PR.

EDIT:
Fortunately had time to do this earlier. 😄

@piotter121 piotter121 marked this pull request as ready for review January 19, 2022 19:39
@piotter121 piotter121 marked this pull request as draft January 19, 2022 20:12
@piotter121 piotter121 marked this pull request as ready for review January 19, 2022 20:27
piotter121 and others added 2 commits January 21, 2022 14:51
BREAKING CHANGE: Bump min versions of Angular and NgRx packages to v13

Closes #206
Replace @ngrx/store INIT and UPDATE imports with hardcoded strings.

This was done to fix a module resolution issue where the tests couldn't
run
@BBlackwo BBlackwo merged commit e9dbef3 into btroncone:master Jan 21, 2022
@BBlackwo
Copy link
Collaborator

🎉 This PR is included in version 13.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@BBlackwo
Copy link
Collaborator

If anyone else wants to have a go at fixing the module resolution issue I raised a new issue for it here #212.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Angular 13
4 participants