-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated to node 12.x #21
Conversation
@btrask my similar v12 support changes for node-pcap, which this is an underlying module for, are about to be committed. Preferably, it would be good to continue for it to be based it based on this repo instead of my fork. Are you still maintaining it? |
Our organization is in trouble with what installation of node_pcap and this library has been failing on node v12 environment. |
@btrask it would be really great if you can merge this PR and release a new version. |
Can someone please approve this PR? |
Sorry everyone I was dead for a while. I'd like to push this patch to npm, but I don't own the package there anymore. @jonahharris do you want to either publish an update or add me as a maintainer again? |
@btrask you've been added back as the maintainer - it's your baby :) |
@jonahharris Thank you! I've added you as a collaborator to this repo, too. @aalwash: I pushed 0.4.0 to npm. Let me know how it goes! |
Thanks @btrask , tested with node12 and it works! Now I need to kick someone from node-red-contrib-pcap to updated their dependencies ;) |
Good to hear it @aalwash. Thanks to @jonahharris for doing all the hard work! |
No description provided.