Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to node 12.x #21

Merged
merged 1 commit into from
Aug 1, 2020
Merged

Updated to node 12.x #21

merged 1 commit into from
Aug 1, 2020

Conversation

jonahharris
Copy link
Contributor

No description provided.

@jonahharris
Copy link
Contributor Author

@btrask my similar v12 support changes for node-pcap, which this is an underlying module for, are about to be committed. Preferably, it would be good to continue for it to be based it based on this repo instead of my fork. Are you still maintaining it?

@moznion
Copy link

moznion commented Dec 9, 2019

Our organization is in trouble with what installation of node_pcap and this library has been failing on node v12 environment.
It seems node_pcap side is ready to support node v12, however, the current status of this library could be a blocker for that: node-pcap/node_pcap#254
I really hope this patch was merged and it'll be published.

@HLeithner
Copy link

@btrask it would be really great if you can merge this PR and release a new version.

@aalwash
Copy link

aalwash commented Aug 1, 2020

Can someone please approve this PR?

@btrask btrask merged commit c2687ac into btrask:master Aug 1, 2020
@btrask
Copy link
Owner

btrask commented Aug 1, 2020

Sorry everyone I was dead for a while.

I'd like to push this patch to npm, but I don't own the package there anymore. @jonahharris do you want to either publish an update or add me as a maintainer again?

@jonahharris
Copy link
Contributor Author

@btrask you've been added back as the maintainer - it's your baby :)

@btrask
Copy link
Owner

btrask commented Aug 6, 2020

@jonahharris Thank you! I've added you as a collaborator to this repo, too.

@aalwash: I pushed 0.4.0 to npm. Let me know how it goes!

@aalwash
Copy link

aalwash commented Aug 7, 2020

Thanks @btrask , tested with node12 and it works!

Now I need to kick someone from node-red-contrib-pcap to updated their dependencies ;)

@btrask
Copy link
Owner

btrask commented Aug 7, 2020

Good to hear it @aalwash. Thanks to @jonahharris for doing all the hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants