Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Chef 17 #93

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update for Chef 17 #93

wants to merge 4 commits into from

Conversation

b-dean
Copy link
Contributor

@b-dean b-dean commented Jun 23, 2021

Work in progress to get some of this stuff working on Chef 17.

  • Use Ruby 3.0.0
  • Use newer Minitest gem Probably not this. The newer minitest is pretty incompatible with minitest-chef-handler gem and I don't want to fix that.
  • Use cookstyle instead of foodcritic and newer versions of various other gems

Also fixes the gem update stuff that's in these dependabot PRs:

b-dean added 4 commits June 23, 2021 17:36
also rename `.kitchen.yml` to `kitchen.yml`
the new test fails because on chef 17 (ruby 3) it never runs any tests
remove the rspec monkey patching (caused by chef requiring inspec) and then reintroduce the minitest monkey patching
- since we no longer depend on `chef_handler` cookbook we need chef 14
- also put gems in the metadata.rb and remove old attributes and resources since this will be a major version change
@b-dean b-dean marked this pull request as ready for review June 28, 2021 21:38
@b-dean
Copy link
Contributor Author

b-dean commented Jun 29, 2021

@btm, the change to require Chef 14+ as well as switching the gem to be defined in metadata.rb probably should make this go to 2.0.0.

If you don't want that I can split this into two PRs, one with the Chef 14+ breaking change stuff, and one with the hack to get RSpec/Inspec to stop messing with minitest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant