Decrease effectiveness of timewarp attack #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately, there doesn't seem to be any interest in fixing this bug. |
cryptorex
reviewed
Jun 15, 2018
src/main.cpp
Outdated
| return state.Invalid(error("CheckBlockHeader(): block timestamp too far in the future"), | ||
| REJECT_INVALID, "time-too-new"); | ||
|
|
||
| // starting at height 158750, decrease to 30 minute window to decrease effectiveness of timewarp attack. |
cryptorex
reviewed
Jun 15, 2018
src/chainparams.cpp
Outdated
| @@ -61,6 +61,7 @@ class CMainParams : public CChainParams { | |||
| nDefaultPort = 1989; | |||
| nMaxTipAge = 24 * 60 * 60; | |||
| nPruneAfterHeight = 100000; | |||
| newTimeRule = 158750; | |||
cryptorex
reviewed
Jun 15, 2018
src/clientversion.h
Outdated
| @@ -19,7 +19,7 @@ | |||
| #define CLIENT_VERSION_MAJOR 1 | |||
| #define CLIENT_VERSION_MINOR 3 | |||
cryptorex
approved these changes
Jun 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This decreases the window of time that a block's timestamp can be in the future from two hours to 30 minutes. I think 30 minutes is still too much -- we can probably get away with 15 minutes but we'll take it one step at a time.