wallet: add new PSBT funding and finalizing methods #711
Conversation
wallet/psbt.go
Outdated
|
|
||
| // We can only sign witness inputs. Everything else must already | ||
| // have been signed or the finalize step later will fail. | ||
| if in.WitnessUtxo == nil { |
There was a problem hiding this comment.
Does this cover nested P2WKH?
There was a problem hiding this comment.
Yes, from the perspective of a signer, a NP2WKH looks exactly like a native SegWit output except that FinalScriptSig is set to a non-empty slice.
There was a problem hiding this comment.
Not sure if I'm missing something, but I don't see that being done here.
There was a problem hiding this comment.
Ah, you're right. I assigned the script to WitnessScript instead of FinalScriptSig. The added test case caught that now. Thanks!
guggero
force-pushed
the
psbt-signing
branch
2 times, most recently
from
0b0fc85
to
a797c79
Compare
wallet/psbt.go
Outdated
|
|
||
| // We can only sign witness inputs. Everything else must already | ||
| // have been signed or the finalize step later will fail. | ||
| if in.WitnessUtxo == nil { |
There was a problem hiding this comment.
Not sure if I'm missing something, but I don't see that being done here.
|
Can you show me how to us this PR with my current LND, so I can test PSBT funding with latest electrum releases? |
|
See lightningnetwork/lnd#4389, that adds PSBT signing to |
|
I updated the PR to include the compatibility fix for patched HW wallets: btcsuite/btcutil#178 I also made sure we always include the non-witness UTXO in our PSBTs as well to make sure we produce packets that can be signed by HW wallets with the newest firmware. |
|
Dependency updated. |
|
Can’t wait to test this out in LND! |
Depends on btcsuite/btcutil#178
Adds the methods
FundPsbtwhich can perform coin selection and/or fee estimation to fund outputs in a PSBT andFinalizePsbtwhich signs known inputs of a PSBT packet.We also add
FetchInputInfoandComputeInputScriptwhich previously resided inlndto make them available to the PSBT signing code and other users ofbtcwallet.