blockchain: don't rely on BlockHeightByHash for prune height calculations #2122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcalvinalvin
changed the title
Pull Request Test Coverage Report for Build 8160298701Details
💛 - Coveralls |
|
How can I help test this? Restarting with this patch? |
I don't think we have reconsiderblock here (should push it from utreexod) so you'd have to restart syncing from scratch unfortunately |
Roasbeef
requested changes
Feb 15, 2024
There was a problem hiding this comment.
Can we re-create the scenarios we've see in the wlid via the full block tests?
btcd/blockchain/fullblocktests/generate.go
Lines 783 to 790 in 13152b3
btcd/blockchain/fullblocks_test.go
Lines 132 to 134 in 13152b3
I've modified the existing I've verified that this error only happens when the node is pruned by running an archive node with The error message given out in the test matches that of the logs from @0xB10C and Sjors and with the logs from when I tested it locally. |
Calling t.Fatal inside db.View makes the test hang on failures. Return the error and call t.Fatal outside of db.View avoids this.
Pruning stale blocks will make the block validation fail for the block that the prune was triggered on as BlockHeightByHash will not return the height for blocks that are not in the main chain. We add a test case to ensure that the test fails in the above case.
kcalvinalvin
force-pushed
the
2024-02-15-dont-rely-on-height-fetching
branch
from
17837af
to
42f313c
Compare
|
Here's my logs for running Without pruning: With pruning: |
Alright, done that. I still have a copy of the old datadir in-case anyone needs it for testing or further debugging. I'll re-add the btcd v0.24 to fork-observer once it's synced. I also made sure to add an RSS feed for lagging nodes. |
kcalvinalvin
force-pushed
the
2024-02-15-dont-rely-on-height-fetching
branch
from
42f313c
to
7ff38e7
Compare
|
Added additional comments in the new code |
halseth
reviewed
Feb 23, 2024
Roasbeef
reviewed
Feb 27, 2024
calculations Since BlockHeightByHash only returns the heights for blocks that are in the main chain, when a block that is stale gets pruned, this will cause an error in the block height lookup and cause an error in block processing. Look up the node directly from the index and if the node isn't found, just skip that node. For utxoCache.lastFlushHash, if that isn't found, just force a flush.
kcalvinalvin
force-pushed
the
2024-02-15-dont-rely-on-height-fetching
branch
from
7ff38e7
to
f2caa8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since BlockHeightByHash only returns the heights for blocks that are in the main chain, when a block that is stale gets pruned, this will cause an error in the block height lookup and cause an error in block processing.
Look up the node directly from the index and if the node isn't found, just skip that node. For utxoCache.lastFlushHash, if that isn't found, just force a flush.
Fixes #2121