chainhash: add support to legacy-marshaled hashes #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Roasbeef - this would be helpful as the BitBoxApp stores json-marshalled transactions, which contain the |
benma
reviewed
Aug 28, 2023
chaincfg/chainhash/hash.go
Outdated
| @@ -118,6 +118,12 @@ func (hash Hash) MarshalJSON() ([]byte, error) { | |||
|
|
|||
| // UnmarshalJSON parses the hash with JSON appropriate string value. | |||
| func (hash *Hash) UnmarshalJSON(input []byte) error { | |||
| // If the fist byte indicates an array, the hash could have been marshalled | |||
guggero
reviewed
Aug 28, 2023
Recent commits 1d6e578 and 72ea23e introduced a change in the way Hashes are serialized and deserialized. This change could cause errors in downstream applications that persisted hashes serialized using the previous methods. This introduces support for legacy-serialized hashes unmarshaling and restores the compatibility with previous versions.
Beerosagos
force-pushed
the
hash-unmarshal
branch
from
2c35074
to
3627816
Compare
Beerosagos
added a commit
to Beerosagos/bitbox-wallet-app
that referenced
this pull request
Apr 29, 2024
Recent btcd updates changed the way hashes are serialized. We proposed a fix (see btcsuite/btcd#2025) to restore backward compatibility. This commit adds a specific test case to ensure that the newer and the legacy serialization methods work.
Beerosagos
added a commit
to Beerosagos/bitbox-wallet-app
that referenced
this pull request
Apr 29, 2024
Recent btcd updates changed the way hashes are serialized. We proposed a fix (see btcsuite/btcd#2025) to restore backward compatibility. This commit adds a specific test case to ensure that the newer and the legacy serialization methods work.
Beerosagos
added a commit
to Beerosagos/bitbox-wallet-app
that referenced
this pull request
Apr 29, 2024
Recent btcd updates changed the way hashes are serialized. We proposed a fix (see btcsuite/btcd#2025) to restore backward compatibility. This commit adds a specific test case to ensure that the newer and the legacy serialization methods work.
Beerosagos
added a commit
to Beerosagos/bitbox-wallet-app
that referenced
this pull request
May 9, 2024
Recent btcd updates changed the way hashes are serialized. We proposed a fix (see btcsuite/btcd#2025) to restore backward compatibility. This commit adds a specific test case to ensure that the newer and the legacy serialization methods work.
Beerosagos
added a commit
to Beerosagos/bitbox-wallet-app
that referenced
this pull request
May 16, 2024
Recent btcd updates changed the way hashes are serialized. We proposed a fix (see btcsuite/btcd#2025) to restore backward compatibility. This commit adds a specific test case to ensure that the newer and the legacy serialization methods work.
Beerosagos
added a commit
to Beerosagos/bitbox-wallet-app
that referenced
this pull request
May 16, 2024
Recent btcd updates changed the way hashes are serialized. We proposed a fix (see btcsuite/btcd#2025) to restore backward compatibility. This commit adds a specific test case to ensure that the newer and the legacy serialization methods work.
NicolaLS
pushed a commit
to NicolaLS/bitbox-wallet-app
that referenced
this pull request
Jun 4, 2024
Recent btcd updates changed the way hashes are serialized. We proposed a fix (see btcsuite/btcd#2025) to restore backward compatibility. This commit adds a specific test case to ensure that the newer and the legacy serialization methods work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent commits 1d6e578 and 72ea23e introduced a change in the way Hashes are serialized and deserialized. This change could cause errors in downstream applications that persisted hashes serialized using the previous methods.
This introduces support for legacy-serialized hashes unmarshaling and restores the compatibility with previous versions.