Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to a proper minor mode #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davidshepherd7
Copy link
Contributor

Hi,

I think sql-indent should be a minor mode (it's uncommon to have code which does something merely by loading it). However changing it to a minor mode now will break peoples configs, which is probably bad, thoughts?

We could also add a custom variable (defaulting to t) and add the hook automatically as it does at the moment if it is true. This would avoid breaking existing configs, but is a bit of a hack.

@bsvingen
Copy link
Owner

I think that's fine, though the alternative would be to fork an sql-indent-2, where changes could be made without restraint.

@purcell
Copy link

purcell commented Apr 18, 2018

FWIW, I think progressive/modernisation changes like this PR should be merged, even if it changes the behaviour for some users. Otherwise, what's the point of maintaining this here? To be complete, of course, changes should update the docs as well as the code. You can conservatively tag certain versions of the code with version numbers in order to make "stable" versions appear in MELPA Stable, but otherwise, I think development should march onwards, and users will generally be willing to receive even slightly breaking improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants