-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HarvestDropsEvent being bypassed when stackDrops is true #33
base: 1.7.10
Are you sure you want to change the base?
Conversation
Hi squeek, I tried to add the code you suggested (in my private modpack) and didn't work. Skill level of my axe still increases itself of 1 point, even if I cut a tree using TreeCapitator... |
I never actually tested it with ITT. I'll try to do that later today. |
Thank you. Could I ask you to keep me updated on your tests, please? |
Ah, @AlexPlus117, just realized that this isn't a fix for the ITT problem. Here's what I posted when I linked to this issue from the ITT issue:
This PR fixes squeek502/VeganOption#30, not the |
Ah, ok. If I don't annoy you, can you give me, privately, the fix for ITT problem, please? |
I'd have to look into it a bit more. Once I do, I'll add the fix to this PR. |
Ok, thank you. |
@AlexPlus117, sorry, but the fix that ITT needs is actually somewhat complicated--simply due to the fact that Treecapitator reimplements so much harvesting functionality that it's hard to figure out where |
Should be safe to merge to 1.8 as well.