Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HarvestDropsEvent being bypassed when stackDrops is true #33

Open
wants to merge 1 commit into
base: 1.7.10
Choose a base branch
from

Conversation

squeek502
Copy link

Should be safe to merge to 1.8 as well.

@AlexPlus117
Copy link

Hi squeek, I tried to add the code you suggested (in my private modpack) and didn't work. Skill level of my axe still increases itself of 1 point, even if I cut a tree using TreeCapitator...

@squeek502
Copy link
Author

I never actually tested it with ITT. I'll try to do that later today.

@AlexPlus117
Copy link

Thank you. Could I ask you to keep me updated on your tests, please?

@squeek502
Copy link
Author

Ah, @AlexPlus117, just realized that this isn't a fix for the ITT problem. Here's what I posted when I linked to this issue from the ITT issue:

I've submitted a pull request that fixes a similar incompatibility and it's gotten no action.

This PR fixes squeek502/VeganOption#30, not the onBlockStartBreak issue that ITT needs. That will require a different fix.

@AlexPlus117
Copy link

Ah, ok. If I don't annoy you, can you give me, privately, the fix for ITT problem, please?

@squeek502
Copy link
Author

I'd have to look into it a bit more. Once I do, I'll add the fix to this PR.

@AlexPlus117
Copy link

Ok, thank you.

@squeek502
Copy link
Author

@AlexPlus117, sorry, but the fix that ITT needs is actually somewhat complicated--simply due to the fact that Treecapitator reimplements so much harvesting functionality that it's hard to figure out where onBlockStartBreak should be called and then detect and fix any unintended effects--and I'm not willing to invest the time necessary to figure everything out. You'll have to find someone more familiar with Treecapitator and who is willing to put in the effort to fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants