Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix#213 : Added image upload component #219

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ShashaankS
Copy link
Contributor

Overview

  1. This PR fixes or fixes part of [Feature Request]: Add dynamic image selection component #213 .
  2. This PR does the following: Adds image upload component as gallery

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
  • The PR is made from a branch that's not called "main/master".

Proof that changes are correct

Screencast.from.08-06-2024.02.12.26.PM.webm

data received by the parent component
Screenshot from 2024-08-07 13-31-07

PR Pointers

  • If you need a review or an answer to a question, and don't have permissions to assign people, leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL".
  • Never force push. If you do, your PR will be closed.

Copy link

netlify bot commented Aug 7, 2024

Deploy Preview for merch-site ready!

Name Link
🔨 Latest commit e89e51c
🔍 Latest deploy log https://app.netlify.com/sites/merch-site/deploys/66b32c435e54190008f68c5d
😎 Deploy Preview https://deploy-preview-219--merch-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AkashPaloju
Copy link
Collaborator

Hi @ShashaankS, firstly thank you for the PR.

Could you please add a delete button (with an 'X' icon) to the top right of each image and implement the delete functionality?

Also, can you please show your cursor in your screen recordings.( You can enable it by clicking the cursor icon next to the shutter button in the Ubuntu screen recording pop-up.) This will help verify that it changes to a pointer when hovering over 'Click to upload new image.'

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants