New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added interfaces #36

Closed

maxlyaptsev wants to merge 1 commit into bsm:main from maxlyaptsev:main

maxlyaptsev commented Jul 17, 2021

Interfaces are cool and allows us to generate mocks, using gomock for example (https://github.com/golang/mock)


          added interfaces

cc8b0d8

dim closed this

Member

dim commented Jul 20, 2021 •

edited

Loading

@maxlyaptsev I generally agree about interfaces, but there's nothing that prevents you from defining those interfaces in your code. There's an on-going (heated) debate around this in the Go community, see e.g. golang/go#13182 (and the original decision https://groups.google.com/g/golang-dev/c/F3l9Iz1JX4g/m/t0J0loRaDQAJ). I don't want to break backwards compatibility of this lib, but I will consider migrating to interfaces in the next major release, when a new https://github.com/go-redis/redis/releases is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet