Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest json pr review #1

Merged
merged 8 commits into from
May 18, 2021
Merged

Latest json pr review #1

merged 8 commits into from
May 18, 2021

Commits on Apr 27, 2021

  1. Switch 'latest' properties to return Releases 

    No failures introduced to test suite on the change.
    @bskinn
    bskinn committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    1cb61d6 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2021

  1. Remove unnecessary scope="function" args 

    Per pypi#8615 (comment)
    @bskinn
    bskinn committed May 17, 2021
    Configuration menu
    Copy the full SHA
    ee873dd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'latest-json' into latest-json-pr-review

    @bskinn
    bskinn committed May 17, 2021
    Configuration menu
    Copy the full SHA
    b1dfd94 View commit details
    Browse the repository at this point in the history

  3. Revise JSON docs to remove 'redirect' mentions 

    JSON API views now directly return, rather than redirecting.

Per
pypi#8615 (review)
    @bskinn
    bskinn committed May 17, 2021
    Configuration menu
    Copy the full SHA
    0306080 View commit details
    Browse the repository at this point in the history

  4. Add guard against a nonexisting 'latest' release 

    In the 'latest' views of views.py, pre-fetch the release
from the project first, then handle appropriately given
the possibility for None.

Addresses the following PR review comments:

-
https://github.com/pypa/warehouse/pull/8615/files/ed0baa180d8bd628e80fcd37450c9d4d60dd5b9d?file-filters%5B%5D=.py#r619663916
-
https://github.com/pypa/warehouse/pull/8615/files/ed0baa180d8bd628e80fcd37450c9d4d60dd5b9d?file-filters%5B%5D=.py#r619663799
-
https://github.com/pypa/warehouse/pull/8615/files/ed0baa180d8bd628e80fcd37450c9d4d60dd5b9d?file-filters%5B%5D=.py#r619663874
    @bskinn
    bskinn committed May 17, 2021
    Configuration menu
    Copy the full SHA
    dc83830 View commit details
    Browse the repository at this point in the history

  5. Add 'latest' views tests for no-release projects 

    For completeness, and to satisfy 100% coverage requirement.
    @bskinn
    bskinn committed May 17, 2021
    Configuration menu
    Copy the full SHA
    a8a0cf4 View commit details
    Browse the repository at this point in the history

  6. Streamline release handling in latest JSON calls 

    Addresses pypi#8615 (comment).

The database queries inline here may be duplicative; will check
in a subsequent commit.
    @bskinn
    bskinn committed May 17, 2021
    Configuration menu
    Copy the full SHA
    9415413 View commit details
    Browse the repository at this point in the history

  7. Remove redundant dbquery in 'latest' JSON 

    The 'latest' members off of the Project model now return
fully-realized Release instances, making a subsequent database
call unnecessary.
    @bskinn
    bskinn committed May 17, 2021
    Configuration menu
    Copy the full SHA
    688d842 View commit details
    Browse the repository at this point in the history