-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest json pr review #1
Commits on Apr 27, 2021
-
Switch 'latest' properties to return Releases
No failures introduced to test suite on the change.
Configuration menu - View commit details
-
Copy full SHA for 1cb61d6 - Browse repository at this point
Copy the full SHA 1cb61d6View commit details
Commits on May 17, 2021
-
Configuration menu - View commit details
-
Copy full SHA for ee873dd - Browse repository at this point
Copy the full SHA ee873ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for b1dfd94 - Browse repository at this point
Copy the full SHA b1dfd94View commit details -
Revise JSON docs to remove 'redirect' mentions
JSON API views now directly return, rather than redirecting. Per pypi#8615 (review)
Configuration menu - View commit details
-
Copy full SHA for 0306080 - Browse repository at this point
Copy the full SHA 0306080View commit details -
Add guard against a nonexisting 'latest' release
In the 'latest' views of views.py, pre-fetch the release from the project first, then handle appropriately given the possibility for None. Addresses the following PR review comments: - https://github.com/pypa/warehouse/pull/8615/files/ed0baa180d8bd628e80fcd37450c9d4d60dd5b9d?file-filters%5B%5D=.py#r619663916 - https://github.com/pypa/warehouse/pull/8615/files/ed0baa180d8bd628e80fcd37450c9d4d60dd5b9d?file-filters%5B%5D=.py#r619663799 - https://github.com/pypa/warehouse/pull/8615/files/ed0baa180d8bd628e80fcd37450c9d4d60dd5b9d?file-filters%5B%5D=.py#r619663874
Configuration menu - View commit details
-
Copy full SHA for dc83830 - Browse repository at this point
Copy the full SHA dc83830View commit details -
Add 'latest' views tests for no-release projects
For completeness, and to satisfy 100% coverage requirement.
Configuration menu - View commit details
-
Copy full SHA for a8a0cf4 - Browse repository at this point
Copy the full SHA a8a0cf4View commit details -
Streamline release handling in latest JSON calls
Addresses pypi#8615 (comment). The database queries inline here may be duplicative; will check in a subsequent commit.
Configuration menu - View commit details
-
Copy full SHA for 9415413 - Browse repository at this point
Copy the full SHA 9415413View commit details -
Remove redundant dbquery in 'latest' JSON
The 'latest' members off of the Project model now return fully-realized Release instances, making a subsequent database call unnecessary.
Configuration menu - View commit details
-
Copy full SHA for 688d842 - Browse repository at this point
Copy the full SHA 688d842View commit details