Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement more-complete SphobjinvError exception hierarchy #118

Open
3 tasks
bskinn opened this issue Jun 4, 2020 · 0 comments
Open
3 tasks

Implement more-complete SphobjinvError exception hierarchy #118

bskinn opened this issue Jun 4, 2020 · 0 comments
Labels
area: api 🤖 topic: exceptions rework ‼️ type: enhancement ✨ Something to add
Milestone
v3.0

Comments

@bskinn
Copy link
Owner

bskinn commented Jun 4, 2020 •
edited
Loading

Regular Python exceptions are explicitly raised at various spots in the codebase.

Better to refactor these to (possibly new) subclasses of SphobjinvError.

Make sure to remove any per-file flake8 error ignores for cmdline.py once the exception handling is (presumably) de-generalized.
@bskinn bskinn added this to the v3.0 milestone Jun 4, 2020
bskinn added a commit that referenced this issue Oct 24, 2020
@bskinn
Add ignores for new PIE786 lint
c434d65 
Local noqa override for conftest.py, because *any* error during
the Sphinx live-load is a failing test.

Blanket override on cmdline.py for now, awaiting the exception
hierarchy rework of #118.
@bskinn bskinn mentioned this issue Jun 4, 2022
Open
bskinn added a commit that referenced this issue Jun 4, 2022
@bskinn
Refactor URL inventory loading and add improved messages
eec6c3e 
Closes #99.

The messages will need to be changed/expanded/etc. once the
exception hierarchy rework of #118 is done.
@bskinn bskinn mentioned this issue Nov 17, 2022
Closed
@bskinn bskinn mentioned this issue Apr 11, 2023
Closed
@bskinn bskinn mentioned this issue Aug 28, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: api 🤖 topic: exceptions rework ‼️ type: enhancement ✨ Something to add
Projects
None yet
Milestone
v3.0
Development

No branches or pull requests
1 participant
@bskinn