Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add username edit feature #59

Merged
merged 6 commits into from
Dec 8, 2023

Conversation

MattPereira
Copy link
Contributor

@MattPereira MattPereira commented Dec 4, 2023

Fixes #60

Summary

  • Split the ProfileDetails section of profile page into its own component
  • Set up a skeleton loader component that shows until all necessary profile data is fetched
  • Added contract read/write for getData and setData functions of UP contract
  • Added edit icon next to user's upDev username with onClick that triggers edit mode
  • Clicking "save" sends the setData transaction to UP contract on mumbai
  • @bshevchenko moved the "not yet verified on Lukso Mainnet" alert to be at top of page so it doesnt interfere with Stan's design
See screenshots of changes

image

image

image

Copy link

vercel bot commented Dec 4, 2023

@MattPereira is attempting to deploy a commit to the Deez Stealth Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Dec 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
updev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 7, 2023 6:36pm

Copy link
Owner

@bshevchenko bshevchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MattPereira all lgtm, but refetch doesn't work. I have to refresh the page to see new name. And looks like there is some bug with "Loading" state. I guess it should be Loading once I click on submit icon and while tx is mining. But instead I've seen it only once when I cancelled one of my transactions: Loading... just stuck there after.

Also I think we should consult Stan about icons

@bshevchenko
Copy link
Owner

Copy link
Owner

@bshevchenko bshevchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job @MattPereira !

@bshevchenko bshevchenko merged commit 0ba53e8 into bshevchenko:main Dec 8, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow user to set a custom upDev username
2 participants