Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Improved esy support #43

Open
wants to merge 2 commits into
base: esy-support
Choose a base branch
from

Conversation

rauanmayemir
Copy link

This PR streamlines the structure towards less hardcoded and more 'esy-way'. ninja-build and ocaml are dependencies, not vendor dumps.

@bsansouci
Copy link
Owner

Hey thanks for opening this. I really appreciate the help. That said I'd like to merge the esy branch inside master, so it's easier to maintain and I can actually dogwood it. For that, I need to keep the same vendored ocaml (and might as well keep ninja). I need it for JS compilation.

I'll merge the esy.json though, if that works :)

@rauanmayemir
Copy link
Author

As long as it brings esy and bsb closer, no worries.

@chenglou
Copy link
Collaborator

yes please!

@bsansouci
Copy link
Owner

Heyyy how's this going? I'd love to get the esy.json merged since it's probably more correct than mine. Did you need to change anything inside bsb that makes the integration better?

@rauanmayemir
Copy link
Author

rauanmayemir commented Jun 5, 2018

Hey! Sorry, I didn't realise you meant merge esy.json from this PR.
Let me clean up unused commits and check that it actually works.

I need to keep the same vendored ocaml

Do you mean the old 4.02?

@bsansouci
Copy link
Owner

No worries! Awesome, thank you so much.

Yeah, for now keeping 4.02.3. I'll address that problem later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants