Add Swift Package Manager support #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejensen
commented
Dec 18, 2020
| @@ -65,8 +65,7 @@ import UIKit | |||
|
|
|||
| self.tweakStore = tweakStore | |||
|
|
|||
| // Are we running on a Mac? If so, then we're in a simulator! | |||
| #if (arch(i386) || arch(x86_64)) | |||
| #if targetEnvironment(simulator) | |||
| @@ -25,7 +25,11 @@ internal extension UIImage { | |||
| // NOTE (bryan): if we just used UIImage(named:_), we get crashes when running in other apps! | |||
| // (Why? Because by default, iOS searches in your app's bundle, but we need to redirect that to the bundle associated with SwiftTweaks | |||
| private convenience init?(inThisBundleNamed imageName: String) { | |||
| #if SWIFT_PACKAGE | |||
| self.init(named: imageName, in: Bundle.module, compatibleWith: nil) | |||
There was a problem hiding this comment.
| import XCTest | ||
| @testable import SwiftTweaks | ||
|
|
||
| class SwiftTweaksTests: XCTestCase { } |
There was a problem hiding this comment.
This type was unused
|
@bryanjclark Please, please! THIS needs to go in, we are trying to get rid of CocoaPods entirely. 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for using SwiftTweaks through the Swift Package Manager.