Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change virial output #399

Merged
merged 5 commits into from
Mar 25, 2023
Merged

Change virial output #399

merged 5 commits into from
Mar 25, 2023

Conversation

brucefan1983
Copy link
Owner

  • Output virial data in 12 columns instead of 2: the first 6 columns for NEP prediction and the last 6 for reference. Ordered as xx, yy, zz, xy, yz, zx.
  • Output dipole data in 6 columns instead of 2: the first 3 columns for NEP prediction and the last 3 for reference. Ordered as x, y, z.
  • Output polarizability data in 12 columns instead of 2: the first 6 columns for NEP prediction and the last 6 for reference. Ordered as xx, yy, zz, xy, yz, zx.
  • Allow for missing dipole and polarizability reference data for the prediction mode.

@brucefan1983 brucefan1983 marked this pull request as ready for review March 24, 2023 18:30
Copy link
Collaborator

@shdchen shdchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice. Passed some quick tests on carbon and HCNOSCl.

@brucefan1983
Copy link
Owner Author

Looks nice. Passed some quick tests on carbon and HCNOSCl.

thanks for testing and fixing a typo.

@shdchen shdchen self-requested a review March 25, 2023 14:10
@brucefan1983 brucefan1983 merged commit 398fc9d into master Mar 25, 2023
@brucefan1983 brucefan1983 deleted the change_virial_output branch March 25, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants