Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

speed up full-batch training by 15% #388

Merged
merged 1 commit into from
Mar 4, 2023
Merged

speed up full-batch training by 15% #388

merged 1 commit into from
Mar 4, 2023

Conversation

brucefan1983
Copy link
Owner

@brucefan1983 brucefan1983 commented Mar 3, 2023 •
edited
Loading

When using full-batch training, the neighbor list does not need to be repeately built, which can speed up training by at least 15%。

@brucefan1983 brucefan1983 marked this pull request as ready for review March 3, 2023 17:53
shdchen
shdchen approved these changes Mar 4, 2023
View reviewed changes
Copy link
Collaborator

@shdchen shdchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@brucefan1983 brucefan1983 merged commit ffd85b0 into master Mar 4, 2023
@brucefan1983 brucefan1983 deleted the nep_neighbor branch March 4, 2023 08:01
@erhart1
Copy link
Collaborator

erhart1 commented Mar 4, 2023

Sweet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shdchen shdchen shdchen approved these changes

@elindgren elindgren Awaiting requested review from elindgren

@yongwangxx yongwangxx Awaiting requested review from yongwangxx

@erhart1 erhart1 Awaiting requested review from erhart1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brucefan1983 @erhart1 @shdchen