Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for choosing shear virial weight #320

Merged
merged 3 commits into from
Nov 19, 2022
Merged

Conversation

brucefan1983
Copy link
Owner

@brucefan1983 brucefan1983 commented Nov 18, 2022

In most cases, the shear virials/pressures in the training data are much smaller than the diagonal ones and it is might be beneficial to increase the weight for the shear part. Now one can use

lambda_shear <value>

in nep.in to set such a weight. Someone tested that a value of 5 can make the prediction of C_44 much more accurate in some material.

To solve #295

@erhart1
Copy link
Collaborator

erhart1 commented Nov 19, 2022

Looks good to me.
I would probably rather include more specifically deformed configurations but this seems works for some.
Do you still want to add a page to the documentation?

@brucefan1983
Copy link
Owner Author

Yes, I will update doc.

@brucefan1983
Copy link
Owner Author

Looks good to me. I would probably rather include more specifically deformed configurations but this seems works for some. Do you still want to add a page to the documentation?

In some cases it is even insufficient to include specifically deformed configurations according to tests by Zhiqiang (I think he has contact you for entory maximization). The problem is the shear virials/moduli are much smaller than diagonal ones in some materials (one order of magnitude smaller).

@brucefan1983
Copy link
Owner Author

I messed up by doing something accidently in master...
perhaps need to start this PR over

@brucefan1983
Copy link
Owner Author

I fixed the conflict and it is ready to merge to master.

documentation has been directly committed to master.

@brucefan1983 brucefan1983 merged commit fb07077 into master Nov 19, 2022
@brucefan1983 brucefan1983 deleted the shear_virial_weight branch November 19, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants