Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 15 compatibility & ChangeDetection on cheatsheet toggle #168

Merged
merged 6 commits into from
Jun 22, 2023

Conversation

ilueckel
Copy link

This merge requests adds

  • build support for Angular 15
  • Changes the cheatsheet toggle to a behavior subject to make use of the build in angular change detection. Otherwise I head to evaluate to complete view for changes just to toggle the cheatsheet

@Coffee-Tea
Copy link
Collaborator

Hey @ilueckel! Thanks for this great PR.
Looks good for me.

Just to double-check was it tested in your project locally?

@ilueckel
Copy link
Author

Hi @Coffee-Tea,
I published it to my local npm repository and used the package from there. So far everything is working fine

@koto
Copy link

koto commented Jun 22, 2023

I can confirm that the PR fixes the issue on my application using hybrid (ng1+ng2). Without the PR, the cheatsheet doesn't open until several seconds passed (change detection is not triggered). With the PR, it's instantaneous.

@Coffee-Tea Coffee-Tea merged commit 995dbd5 into brtnshrdr:master Jun 22, 2023
@Coffee-Tea
Copy link
Collaborator

@ilueckel @koto Thanks for your inputs here.
v15 is released https://www.npmjs.com/package/angular2-hotkeys?activeTab=versions
Could u pls test it out form npm? Thanks!

@Coffee-Tea
Copy link
Collaborator

hey @ilueckel could u please let me know why @types/mousetrap moved to devDeps from deps in package.json here?

I would like to clarify that in the scope of #170

Cc @negibouze

@ilueckel
Copy link
Author

ilueckel commented Aug 31, 2023

Hi,
that's my bad - I oversaw that MouseTrapInstance was exported in HotkeysService. I'll create a new pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants